This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Update libraries #8155
Merged
Update libraries #8155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
May 16, 2020
| <ObjectWriterVersion Condition="'$(ObjectWriterVersion)' == ''">1.0.0-alpha-28820-01</ObjectWriterVersion> | ||
| <CoreDisToolsVersion Condition="'$(CoreDisToolsVersion)' == ''">1.0.1-prerelease-00005</CoreDisToolsVersion> | ||
| <RuntimeLibrariesVersion Condition="'$(RuntimeLibrariesVersion)' == ''">5.0.0-preview.2.20153.3</RuntimeLibrariesVersion> | ||
| <RuntimeLibrariesVersion Condition="'$(RuntimeLibrariesVersion)' == ''">5.0.0-preview.5.20263.12</RuntimeLibrariesVersion> |
Member
Author
There was a problem hiding this comment.
This is likely the last one libraries bump that we can do in CoreRT. Going further requires new Roslyn that requires new tools SDK. We will need to get the move to dotnet/runtimelab done for that.
MichalStrehovsky
approved these changes
May 16, 2020
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
This is likely the last one libraries bump that we can do in CoreRT. Going further requires new Roslyn that requires new tools SDK. We will need to get the move to dotnet/runtimelab done for that.
Sigh. Thank you!
Sorry about missing porting the Nullable change!
Suchiman
added a commit
to Suchiman/corert
that referenced
this pull request
Aug 17, 2020
Got lost in dotnet#8155
Merged
MichalStrehovsky
pushed a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.